]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
keyring: Use bind_property for message and description values
authorMarco Trevisan (Treviño) <mail@3v1n0.net>
Thu, 25 Apr 2019 19:29:45 +0000 (14:29 -0500)
committerFlorian Müllner <florian.muellner@gmail.com>
Wed, 15 May 2019 18:37:45 +0000 (18:37 +0000)
This code was commented out in commit 593b431 as it was causing a crash in gjs.

As per the [1] gjs fix, this can now be safely used again.

[1] https://gitlab.gnome.org/GNOME/gjs/merge_requests/289
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/510

js/ui/components/keyring.js

index 0d9f1e4663f8b1d3458ef56b8e38dfa80d70bd26..ab0793f54f891ea9d2d68fd17f81c9ee1e194224 100644 (file)
@@ -23,20 +23,8 @@ var KeyringDialog = class extends ModalDialog.ModalDialog {
         this._content = new Dialog.MessageDialogContent({ icon });
         this.contentLayout.add(this._content);
 
-        // FIXME: Why does this break now?
-        /*
         this.prompt.bind_property('message', this._content, 'title', GObject.BindingFlags.SYNC_CREATE);
         this.prompt.bind_property('description', this._content, 'body', GObject.BindingFlags.SYNC_CREATE);
-        */
-        this.prompt.connect('notify::message', () => {
-            this._content.title = this.prompt.message;
-        });
-        this._content.title = this.prompt.message;
-
-        this.prompt.connect('notify::description', () => {
-            this._content.body = this.prompt.description;
-        });
-        this._content.body = this.prompt.description;
 
         this._workSpinner = null;
         this._controlTable = null;